New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve description for tf.test.is_gpu_available #27566
Conversation
any updates on this one? @annarev @ymodak @dynamicwebpaige |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding this description. 🙂
PiperOrigin-RevId: 244740935
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the change!
@@ -1331,13 +1331,17 @@ def decorated(self, *args, **kwargs): | |||
def is_gpu_available(cuda_only=False, min_cuda_compute_capability=None): | |||
"""Returns whether TensorFlow can access a GPU. | |||
|
|||
Warning: if not GPU version of the package is installed, the function would |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"non-GPU" sounds better than "not GPU" to me.
@@ -1331,13 +1331,17 @@ def decorated(self, *args, **kwargs): | |||
def is_gpu_available(cuda_only=False, min_cuda_compute_capability=None): | |||
"""Returns whether TensorFlow can access a GPU. | |||
|
|||
Warning: if not GPU version of the package is installed, the function would | |||
also, return False. Use `tf.test.is_built_with_cuda` to validate if TensorFlow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant comma here "also, return False"
oops, didn't realize it is already merged. |
As a part of TensorFlow docs sprints from Munich.
A small explanation for added warning - https://colab.research.google.com/drive/10pT_SQBAbZm9yVcoaACgrAlQ3YbpM_RI
cc @dynamicwebpaige