Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description for tf.test.is_gpu_available #27566

Merged
merged 2 commits into from Apr 22, 2019

Conversation

lc0
Copy link
Contributor

@lc0 lc0 commented Apr 6, 2019

As a part of TensorFlow docs sprints from Munich.

A small explanation for added warning - https://colab.research.google.com/drive/10pT_SQBAbZm9yVcoaACgrAlQ3YbpM_RI

cc @dynamicwebpaige

@rthadur rthadur self-assigned this Apr 7, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 7, 2019
@rthadur rthadur requested a review from ymodak April 7, 2019 04:43
@rthadur rthadur added size:XS CL Change Size: Extra Small type:docs-bug Document issues labels Apr 7, 2019
@rthadur rthadur requested a review from annarev April 7, 2019 04:44
@lc0
Copy link
Contributor Author

lc0 commented Apr 11, 2019

any updates on this one? @annarev @ymodak @dynamicwebpaige

Copy link
Contributor

@dynamicwebpaige dynamicwebpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this description. 🙂

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 22, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 22, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 22, 2019
@tensorflow-copybara tensorflow-copybara merged commit 0ec1786 into tensorflow:master Apr 22, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 22, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 22, 2019
Copy link
Contributor

@annarev annarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change!

@@ -1331,13 +1331,17 @@ def decorated(self, *args, **kwargs):
def is_gpu_available(cuda_only=False, min_cuda_compute_capability=None):
"""Returns whether TensorFlow can access a GPU.

Warning: if not GPU version of the package is installed, the function would
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"non-GPU" sounds better than "not GPU" to me.

@@ -1331,13 +1331,17 @@ def decorated(self, *args, **kwargs):
def is_gpu_available(cuda_only=False, min_cuda_compute_capability=None):
"""Returns whether TensorFlow can access a GPU.

Warning: if not GPU version of the package is installed, the function would
also, return False. Use `tf.test.is_built_with_cuda` to validate if TensorFlow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant comma here "also, return False"

@annarev
Copy link
Contributor

annarev commented Apr 22, 2019

oops, didn't realize it is already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small type:docs-bug Document issues
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants